fix: resolve all failing tests across api and shared packages#12
Open
stooit wants to merge 1 commit into
Open
Conversation
- Fix auth middleware case-sensitivity bug in HTTP method comparison - Add missing badRequest import in users route handler - Rename userName to username in shared User type for consistency - Implement paginate utility function with 1-indexed page support
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
badRequestimport that caused 500 errors instead of proper 400 validation responsesuserNamefield tousernamein theUsertype to match the API contract expected by consumerspaginatefunction (previously a stub) with 1-indexed page supportTesting
All 22 tests pass across 4 test files. No type errors in source files (
npx tsc --noEmitclean except for expected environment-specificbun:testmodule resolution).Assumptions
badRequesthelper follows the same pattern as other response helpers in the codebase